Fix race condition between setInput() and focus() of SCMInputWidget #190878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsfzxjy
force-pushed
the
scm-no-focus-first-time-184155
branch
from
6f58e15 to
5585845
Compare
hsfzxjy
force-pushed
the
scm-no-focus-first-time-184155
branch
6 times, most recently
from
483c5a7 to
e9dfd54
Compare
hsfzxjy
force-pushed
the
scm-no-focus-first-time-184155
branch
from
e9dfd54 to
5ac0133
Compare
mjmatthiesen
approved these changes
Mar 26, 2024
Member
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #184155
This bug is caused by a subtle race conditon in SCMInputWidget.
When calling
SCMInputWidget.focus(), it checks whether model data was set on the input and rejects to focus if not the case. (ref: https://github.com/microsoft/vscode/blob/main/src/vs/editor/browser/widget/codeEditorWidget.ts#L1424 )Prior to commit f6e9a38 ,
setInput()was a sync method and it will finish before the firstfocus()would be called.After that commit, however,
setInput()was changed to an async method, and there's no guarantee that model data would be set before the firstfocus()being called.This PR fixes the race condition and thus the issue.