fix textarea sync issue #194916
Closed
fix textarea sync issue #194916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Oct 5, 2023
| // position to update as conpty often prints the sequence on a different line to the | ||
| // actual line the command started on. | ||
| timeout(0).then(() => { | ||
| timeout(20).then(() => { |
Contributor
Author
There was a problem hiding this comment.
do we want to do this only for screen reader users?
meganrogge
commented
Oct 5, 2023
src/vs/workbench/contrib/terminalContrib/accessibility/browser/textAreaSyncAddon.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
there's still one issue - occasionally, the prompt does not come through. when that happens, the first 4 chars I type aren't synced in the text area. if i keep typing, they get added. EDIT: having a hard time reproducing that now.
|
meganrogge
commented
Oct 9, 2023
Comment on lines
+513
to
+526
| "@mole-inc/bin-wrapper@^8.0.1": | ||
| version "8.0.1" | ||
| resolved "https://registry.yarnpkg.com/@mole-inc/bin-wrapper/-/bin-wrapper-8.0.1.tgz#d7fd0ceb1cfa8a855293a3ed9d7d135f4d442f0e" | ||
| integrity sha512-sTGoeZnjI8N4KS+sW2AN95gDBErhAguvkw/tWdCjeM8bvxpz5lqrnd0vOJABA1A+Ic3zED7PYoLP/RANLgVotA== | ||
| dependencies: | ||
| bin-check "^4.1.0" | ||
| bin-version-check "^5.0.0" | ||
| content-disposition "^0.5.4" | ||
| ext-name "^5.0.0" | ||
| file-type "^17.1.6" | ||
| filenamify "^5.0.2" | ||
| got "^11.8.5" | ||
| os-filter-obj "^2.0.0" | ||
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #193456