style: remove the default activity bar icon size

[jiawei-hong]

fix #197648

before

after

[gjsjohnmurray]

Does this affect how badges look? One way to check is to downgrade one of your extensions, then check for updates. The Extensions activity icon should display a number badge.

[gjsjohnmurray]

pinging @sandy081

[jiawei-hong]

@gjsjohnmurray I don't think this change will affect the badge, Below is my test under the dark modern theme and high contrast theme

Dark Modern Theme

Dark High Contrast theme

[sandy081]

Activity bar icon size is made bigger for a reason. So, I would not like to remove that. If outline border is the problem, should that be fixed?

[jiawei-hong]

Activity bar icon size is made bigger for a reason. So, I would not like to remove that. If outline border is the problem, should that be fixed?

I don't think the outline border is the problem; the real problem is that the ::before element width exceeds the a tag width
We can directly set the a tag width to be equal to the font-size of the ::before element

Will new problem or concern if I set a tag width is equal to the font-size of the ::before element

[sandy081]

Will new problem or concern if I set a tag width is equal to the font-size of the ::before element

Should not be. Please check if the outline and badges are looking fine after the change.