Skip to content

Conversation

@samhanic
Copy link
Contributor

Fixes #196155

This PR add to the --list-extensions command (in the extension management CLI) an option --show-origin that return the origin of each extension while listing them.
It will allow external tools that use this command to parse this result and distinguish between:

  • Released extensions in the marketplace
  • Prerelease extensions from the marketplace
  • Not published (i.e. vscx) extensions

Example of return:

$ ./scripts/code-cli.sh --list-extensions --show-origin
ms-python.python (prerelease)
ms-python.vscode-pylance (marketplace)
vscode-sampless.helloworld-sample (vscx)

This is also compatible with --show-versions argument:

$ ./scripts/code-cli.sh --list-extensions --show-versions --show-origin
ms-python.python@2023.21.13141007 (prerelease)
ms-python.vscode-pylance@2023.11.10 (marketplace)
vscode-sampless.helloworld-sample@0.0.1 (vscx)

This have been linted using yarn and tested with the provided test.sh script.

@samhanic
Copy link
Contributor Author

@microsoft-github-policy-service agree

@sandy081
Copy link
Member

The associated feature is only asking whether the extension is a pre-release or not. Please stick to that.

@samhanic
Copy link
Contributor Author

The associated feature is only asking whether the extension is a pre-release or not. Please stick to that.

Quoting the issue #196155:
The feature should be used to distinguish between different extension types.
In particular, it needs to distinguish between extensions:

1. From the marketplace (published)
    - Release
    - Pre-release
 2. Not published

From that quotes I have no doubts this PR is sticking to the issue description.

@sandy081
Copy link
Member

Thanks for sharing the info. I did not read that comment. Summary and Description says only about the pre-release. Lets stick to that. I would not go with extension type.

@samhanic
Copy link
Contributor Author

samhanic commented Dec 3, 2023

Closing this PR as it has been superseded by #199894 and #199893

@samhanic samhanic closed this Dec 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI] --list-extensions --show-versions should annotate the packages that are in pre-release

2 participants