editor: include lane in GUTTER_GLYPH_MARGIN hover events#202194
Merged
connor4312 merged 2 commits intomainfrom Jan 10, 2024
Merged
editor: include lane in GUTTER_GLYPH_MARGIN hover events#202194connor4312 merged 2 commits intomainfrom
connor4312 merged 2 commits intomainfrom
Conversation
Also fixes handling of testing clicks and margin hovers which were not aware of multiple lanes. Hover messages are now shown correctly and tests no longer run if e.g. a breakpoint decoration on the same line is clicked. Note sure if this was the best way to do this, let me know.
andreamah
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes handling of testing clicks and margin hovers which were not
aware of multiple lanes. Hover messages are now shown correctly and
tests no longer run if e.g. a breakpoint decoration on the same line is
clicked.
Fixes handling of decorations when word wrap is on as well.
Note sure if this was the best way to do this, let me know.