Skip to content

Fix issue with "reun without" while request is pending#213926

Merged
jrieken merged 2 commits intomainfrom
joh/subjective-hedgehog
May 30, 2024
Merged

Fix issue with "reun without" while request is pending#213926
jrieken merged 2 commits intomainfrom
joh/subjective-hedgehog

Conversation

@jrieken
Copy link
Copy Markdown
Member

@jrieken jrieken commented May 30, 2024

  • send out ChatRequestRemovalReason
  • make inline chat re-enter SHOW_REQUEST when resending an active request
  • the SHOW_REQUEST state should be prepared to come after the request has started
  • more cancellation checking with asProgressiveEdit
  • add tests

- send out `ChatRequestRemovalReason`
- make inline chat re-enter `SHOW_REQUEST` when resending an active request
- the `SHOW_REQUEST` state should be prepared to come after the request has started
- more cancellation checking with `asProgressiveEdit`
- add tests

microsoft/vscode-copilot#5997
@jrieken jrieken self-assigned this May 30, 2024
@jrieken jrieken enabled auto-merge (squash) May 30, 2024 17:07
@vscodenpa vscodenpa added this to the May 2024 milestone May 30, 2024
@jrieken jrieken merged commit 135c59a into main May 30, 2024
@jrieken jrieken deleted the joh/subjective-hedgehog branch May 30, 2024 18:39
@microsoft microsoft locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants