Skip to content

adopt chat agent in terminal chat, fix a few bugs#214499

Merged
meganrogge merged 17 commits intomainfrom
merogge/terminal-chat-refactor
Jun 7, 2024
Merged

adopt chat agent in terminal chat, fix a few bugs#214499
meganrogge merged 17 commits intomainfrom
merogge/terminal-chat-refactor

Conversation

@meganrogge
Copy link
Copy Markdown
Collaborator

@meganrogge meganrogge commented Jun 6, 2024

@meganrogge meganrogge self-assigned this Jun 6, 2024
@meganrogge meganrogge marked this pull request as draft June 6, 2024 18:47
@meganrogge meganrogge added this to the June 2024 milestone Jun 6, 2024
@meganrogge meganrogge requested a review from Tyriar June 6, 2024 19:04
@meganrogge meganrogge marked this pull request as ready for review June 6, 2024 19:44
@Tyriar
Copy link
Copy Markdown
Contributor

Tyriar commented Jun 7, 2024

Follow ups are being shown on top which obscures the content:

image

@Tyriar
Copy link
Copy Markdown
Contributor

Tyriar commented Jun 7, 2024

Pressing escape now seems to clear the chat but not hide it:

image

@meganrogge
Copy link
Copy Markdown
Collaborator Author

Pressing escape now seems to clear the chat but not hide it:

image

Cannot repro on mac 🤔

Comment thread src/vs/workbench/contrib/inlineChat/browser/inlineChatWidget.ts
Comment thread src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatActions.ts Outdated
Comment thread src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatActions.ts Outdated
Comment thread src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatController.ts Outdated
@meganrogge meganrogge enabled auto-merge (squash) June 7, 2024 20:01
@meganrogge meganrogge requested a review from Tyriar June 7, 2024 20:01
@meganrogge meganrogge changed the title adopt chat agent in terminal chat adopt chat agent in terminal chat, fix a few bugs Jun 7, 2024
@meganrogge meganrogge merged commit 52c722c into main Jun 7, 2024
@meganrogge meganrogge deleted the merogge/terminal-chat-refactor branch June 7, 2024 20:20
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fully adopt agents for terminal inline chat

2 participants