support terminal chat accessible view actions, fix content#229448
Merged
meganrogge merged 4 commits intomainfrom Oct 1, 2024
Merged
support terminal chat accessible view actions, fix content#229448meganrogge merged 4 commits intomainfrom
meganrogge merged 4 commits intomainfrom
Conversation
Tyriar
reviewed
Sep 26, 2024
Contributor
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
@meganrogge how do I make those icons show up? Is that this PR that's adding them? I see some problems with them:
- The stop icon is blurry
- The "package" icon is blue
- I'm not sure what most of them do
Collaborator
Author
|
yes, this PR adds them. the accessible view is for screen reader users, so I have never cared too much about the icons. |
Contributor
|
The accessible view can also be useful for low vision individuals, but regardless we should have good icons or not have icons associated with these actions at all. Some users who can see them may come across the blurry and colored icons and they make the UI look sloppy. |
meganrogge
changed the title
rzhao271
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #210256