fix image rendering, use paste provider#229779
Merged
justschen merged 17 commits intomicrosoft:mainfrom Oct 7, 2024
Merged
Conversation
benibenj
reviewed
Sep 26, 2024
Contributor
benibenj
left a comment
benibenj
left a comment
There was a problem hiding this comment.
FYI, in this case you can use the ChatContextAttachments contribution which also takes care of duplicates. We are not able to use it for chat dnd sadly.
mjbvz
requested changes
Sep 30, 2024
| } | ||
|
|
||
| const attachContribution = widget.getContrib<ChatContextAttachments>(ChatContextAttachments.ID); | ||
| attachContribution?.setContext(false, imageContext); |
Collaborator
There was a problem hiding this comment.
provideDocumentPasteEdits should not have any side effects. Maybe ok as a temporary workaround for now but let's look into allowing workspace edits to add attachments to chat. That way undo/redo will work nicely too
mjbvz
reviewed
Oct 2, 2024
mjbvz
previously approved these changes
Oct 7, 2024
Collaborator
mjbvz
left a comment
mjbvz
left a comment
There was a problem hiding this comment.
Approving for continued iteration but please make sure to follow up about using workspace edits
rzhao271
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this moves
chatImagePastecontent intochatPasteProviderwhich is invoked on paste.fixes #229625 and https://github.com/microsoft/vscode-copilot/issues/8637
cc. @benibenj
paste:
Screen.Recording.2024-09-25.at.4.21.11.PM.mov
dnd:
secondone.mov