Skip to content

build: make sdl scan gulp tasks lazy#230239

Merged
deepak1556 merged 1 commit intomainfrom
robo/fix_watch_task
Oct 1, 2024
Merged

build: make sdl scan gulp tasks lazy#230239
deepak1556 merged 1 commit intomainfrom
robo/fix_watch_task

Conversation

@deepak1556
Copy link
Copy Markdown
Collaborator

Fixes #230200

gulpfile.scan.js was eagerly evaluating the dependency extraction as a side effect of loading the gulpfile via

vscode/build/gulpfile.js

Lines 51 to 53 in 516ecdd

// Load all the gulpfiles only if running tasks other than the editor tasks
require('glob').sync('gulpfile.*.js', { cwd: __dirname })
.forEach(f => require(`./${f}`));
. This interferes with build task when switching branches that could contain possibly different dependency trees. The task is only meant to run in SDL scan CI on demand, so make the relevant calls lazy as well.

/cc @rzhao271

@deepak1556 deepak1556 added this to the October 2024 milestone Oct 1, 2024
@deepak1556 deepak1556 self-assigned this Oct 1, 2024
@deepak1556 deepak1556 enabled auto-merge (squash) October 1, 2024 14:27
Comment thread build/gulpfile.scan.js Outdated
@deepak1556 deepak1556 force-pushed the robo/fix_watch_task branch from 40ec0a2 to 0c1b6b0 Compare October 1, 2024 15:38
@deepak1556 deepak1556 requested a review from Tyriar October 1, 2024 15:39
@deepak1556 deepak1556 merged commit e134965 into main Oct 1, 2024
@deepak1556 deepak1556 deleted the robo/fix_watch_task branch October 1, 2024 23:56
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot run build task anymore

2 participants