Resetting screen reader text to use LineFeed#230475
Merged
Conversation
aiday-mar
changed the title
Tyriar
reviewed
Oct 4, 2024
Comment on lines
+410
to
+411
| const options = this._context.configuration.options; | ||
| const accessibilitySupportEnabled = options.get(EditorOption.accessibilitySupport); |
Contributor
There was a problem hiding this comment.
Should you be using IAccessibilityService for this?
Contributor
Author
There was a problem hiding this comment.
Ah yes I see there is a method which checks if accessibility mode is enabled. I will use that instead.
TylerLeonhardt
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resetting screen reader text to use LineFeed
Calculate the offsets for
selectionchangeevent differentlyFixes issue mentioned in #229051