re-add terminal voice action, stop it when appropriate#230552
Merged
meganrogge merged 2 commits intorelease/1.94from Oct 8, 2024
Merged
re-add terminal voice action, stop it when appropriate#230552meganrogge merged 2 commits intorelease/1.94from
meganrogge merged 2 commits intorelease/1.94from
Conversation
…e `acceptInput` so recording stops appropriately (#230529)
Collaborator
Author
|
waiting to merge until after tomorrow's release |
roblourens
reviewed
Oct 7, 2024
src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatController.ts
Show resolved
Hide resolved
roblourens
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced by a refactoring from @roblourens, but really was caused by the terminal handling things differently from other chats.
fixes #230330
The bug/regression fix was deemed
verification-foundright before I went on vacation. I wasn't reproducing the bug because had a setting that obscured it enabled.fixes #229025