[1035] potential listener LEAK detected, having 175 listeners already. MOST frequent listener (1):#232569
Merged
[1035] potential listener LEAK detected, having 175 listeners already. MOST frequent listener (1):#232569
Conversation
…. MOST frequent listener (1): Fixes #232400
alexr00
commented
Oct 30, 2024
| } | ||
| })); | ||
|
|
||
| // We just look at registry changes to determine whether to use tree sitter. |
Member
Author
There was a problem hiding this comment.
Should be safe to because the same event is listened on in the TextModel:
vscode/src/vs/editor/common/model/textModel.ts
Lines 386 to 389 in df257e1
Which calls handleLanguageConfigurationServiceChange, which does the same exact thing:
vscode/src/vs/editor/common/model/tokenizationTextModelPart.ts
Lines 115 to 119 in df257e1
hediet
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #232400