Skip to content

[1035] potential listener LEAK detected, having 175 listeners already. MOST frequent listener (1):#232569

Merged
hediet merged 1 commit intomainfrom
alexr00/issue232400
Oct 30, 2024
Merged

[1035] potential listener LEAK detected, having 175 listeners already. MOST frequent listener (1):#232569
hediet merged 1 commit intomainfrom
alexr00/issue232400

Conversation

@alexr00
Copy link
Copy Markdown
Member

@alexr00 alexr00 commented Oct 30, 2024

Fixes #232400

@alexr00 alexr00 self-assigned this Oct 30, 2024
}
}));

// We just look at registry changes to determine whether to use tree sitter.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be safe to because the same event is listened on in the TextModel:

this._register(this._languageConfigurationService.onDidChange(e => {
this._bracketPairs.handleLanguageConfigurationServiceChange(e);
this._tokenizationTextModelPart.handleLanguageConfigurationServiceChange(e);
}));

Which calls handleLanguageConfigurationServiceChange, which does the same exact thing:

public handleLanguageConfigurationServiceChange(e: LanguageConfigurationServiceChangeEvent): void {
if (e.affects(this._languageId)) {
this._onDidChangeLanguageConfiguration.fire({});
}
}

@alexr00 alexr00 requested a review from hediet October 30, 2024 08:55
@alexr00 alexr00 marked this pull request as ready for review October 30, 2024 08:55
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Oct 30, 2024
@hediet hediet merged commit adfb37d into main Oct 30, 2024
@hediet hediet deleted the alexr00/issue232400 branch October 30, 2024 09:06
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1035] potential listener LEAK detected, having 175 listeners already. MOST frequent listener (1):

2 participants