EditContext: Removing surfacing of the textAreaDomNode on ICodeEditor - refactoring#232957
Merged
EditContext: Removing surfacing of the textAreaDomNode on ICodeEditor - refactoring#232957
textAreaDomNode on ICodeEditor - refactoring#232957Conversation
Contributor
Author
|
Will check if this is necessary |
aiday-mar
changed the title
textAreaDomNode on ICodeEditortextAreaDomNode on ICodeEditor - refactoring
anthonykim1
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently I have added the method
getTextAreaDomNodeon theICodeEditorinterface.This can now be accessed by all the users of the ICodeEditor.
The only instance where this is needed is in the clipboard.ts file.
So instead in this PR I directly fetch the text area
This code is not clean, but serves as a workaround because a dom node which has an edit context set, can not receive a 'paste' command execution. The text area is needed in order to be able to call
execCommand('paste')on it and handle the paste event