Skip to content

fix: synchronous script loading from web workers of extensions#233175

Merged
deepak1556 merged 2 commits intomicrosoft:mainfrom
pankajk07:pankajk07-patch-1
Dec 6, 2024
Merged

fix: synchronous script loading from web workers of extensions#233175
deepak1556 merged 2 commits intomicrosoft:mainfrom
pankajk07:pankajk07-patch-1

Conversation

@pankajk07
Copy link
Copy Markdown
Contributor

@pankajk07 pankajk07 commented Nov 6, 2024

Refs #233060

Copy link
Copy Markdown
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I would like some time to investigate the underlying cause and the impact before pushing this as a fix.

You can always launch the application with the flag irrespective of this PR.

@mcpeakdb
Copy link
Copy Markdown

mcpeakdb commented Dec 3, 2024

hello, is there anything the community can do to help expedite this fix?

@deepak1556 deepak1556 enabled auto-merge (squash) December 6, 2024 13:46
@deepak1556 deepak1556 added this to the January 2025 milestone Dec 6, 2024
@deepak1556 deepak1556 changed the title fix: disabled PlzDedicatedWorker in Electron fix: synchronous script loading from web workers of extensions Dec 6, 2024
@deepak1556 deepak1556 merged commit ad42640 into microsoft:main Dec 6, 2024
@pankajk07 pankajk07 deleted the pankajk07-patch-1 branch December 7, 2024 12:08
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants