fix: cannot open vscode when use vscode-win32-x64 in Windows#233285
Merged
bpasero merged 1 commit intomicrosoft:mainfrom Nov 8, 2024
Merged
fix: cannot open vscode when use vscode-win32-x64 in Windows#233285bpasero merged 1 commit intomicrosoft:mainfrom
bpasero merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
bpasero
requested changes
Nov 8, 2024
Member
bpasero
left a comment
There was a problem hiding this comment.
There also seems to be another case here:
vscode/build/gulpfile.vscode.web.js
Lines 93 to 112 in 4ad5865
53ac921 to
5e03a99
Compare
Contributor
Author
|
@bpasero Done |
Member
|
Thanks, we are actually checking in the related JS file as well, so can you run a |
When executing `npm run gulp vscode-win32-x64` on the Windows platform, the `bundle-vscode` task is triggered. However, this task does not handle the path issues well, resulting in the contents of the `bootstrap-window.js` file not being injected into `workbench.js` and `processExplorer.js`. The reason why VSCode does not encounter this issue is that the code compilation (compile-build) is performed on a Linux machine, while the Windows machine only executes the application build (vscode-win32-x64-ci will not trigger `bundle-vscode`). Signed-off-by: Kevin Cui <bh@bugs.cc>
5e03a99 to
876b656
Compare
Contributor
Author
|
@bpasero Completed. |
bpasero
approved these changes
Nov 8, 2024
lszomoru
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing
npm run gulp vscode-win32-x64on the Windows platform, thebundle-vscodetask is triggered. However, this task does not handle the path issues well, resulting in the contents of thebootstrap-window.jsfile not being injected intoworkbench.jsandprocessExplorer.js.The reason why VSCode does not encounter this issue is that the code compilation (compile-build) is performed on a Linux machine, while the Windows machine only executes the application build (vscode-win32-x64-ci will not trigger
bundle-vscode).PTAL @deepak1556