Conversation
joyceerhl
reviewed
Nov 21, 2024
| if (this._location.location === ChatAgentLocation.EditingSession) { | ||
| this.chatEditingService.createSnapshot(e.request.id); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Why do we not need to take snapshots anymore? Would this not break undo/redo, or does that happen some other way now?
Contributor
Author
There was a problem hiding this comment.
No change, but it moved to inside the chatEditingService:
joyceerhl
approved these changes
Nov 21, 2024
osortega
pushed a commit
that referenced
this pull request
Nov 26, 2024
* edits: more simplifications * remove unused imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.