Remove type assertions for createInstance calls on generics#234623
Merged
mjbvz merged 4 commits intomicrosoft:mainfrom Nov 26, 2024
Merged
Remove type assertions for createInstance calls on generics#234623mjbvz merged 4 commits intomicrosoft:mainfrom
createInstance calls on generics#234623mjbvz merged 4 commits intomicrosoft:mainfrom
Conversation
These can hide typing errors
connor4312
previously approved these changes
Nov 25, 2024
Member
connor4312
left a comment
connor4312
left a comment
There was a problem hiding this comment.
I feel like this is a syntax I tried a long time ago and it didn't work, is it new? 🤔
Collaborator
Author
|
@connor4312 It definitely didn't exist when we first converted the codebase to be strict null checked. That's when most of these assertions got introduced. But I think it's been around a few years and this point although I can't say exactly when it came in |
Missed fixing one revealed typing error
connor4312
approved these changes
Nov 25, 2024
songjianet
approved these changes
Nov 26, 2024
Member
|
@microsoft-github-policy-service rerun |
rzhao271
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These can hide typing errors