Skip to content

don't request terminal completions if cursor index < 0#238385

Merged
meganrogge merged 1 commit intomainfrom
merogge/fix-issue2
Jan 21, 2025
Merged

don't request terminal completions if cursor index < 0#238385
meganrogge merged 1 commit intomainfrom
merogge/fix-issue2

Conversation

@meganrogge
Copy link
Copy Markdown
Collaborator

fix #238380

@meganrogge meganrogge requested a review from Tyriar January 21, 2025 17:38
@meganrogge meganrogge self-assigned this Jan 21, 2025
@meganrogge meganrogge added this to the January 2025 milestone Jan 21, 2025
@meganrogge meganrogge enabled auto-merge (squash) January 21, 2025 17:38
@meganrogge
Copy link
Copy Markdown
Collaborator Author

meganrogge commented Jan 21, 2025

After a command is executed, we set it to -1. When there's next input, if there's prompt input detection IE shell integration, we set the value again. Thus, when it's set to -1, it means we do not have knowledge of where the cursor is.

Running ls then typing a char, which is detected bc shell integration still works

Screenshot 2025-01-21 at 2 25 45 PM

Running bash then typing a char, which is not detected bc no shell integration is present, so it remains -1

Screenshot 2025-01-21 at 2 26 34 PM

@meganrogge meganrogge merged commit 9542cdb into main Jan 21, 2025
@meganrogge meganrogge deleted the merogge/fix-issue2 branch January 21, 2025 20:30
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can trigger terminal suggest even without shell integration

2 participants