Merged
Conversation
Tyriar
previously requested changes
Feb 10, 2025
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
For . I think we do actually want the builtin, but it should have more information in this case saying it's an alias for source (we'd need to make sure this is actually correct). The reason I think it's better than the . path is because if you complete it, it would use the source route, not the folder.
meganrogge
force-pushed
the
merogge/duplicate
branch
from
10ac464 to
03310e3
Compare
meganrogge
changed the title
. as we provide it in resolveResources. completion
meganrogge
force-pushed
the
merogge/duplicate
branch
from
7fb39fd to
004c511
Compare
Tyriar
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #234362
