Ignore internal cell id when computing cell hash for diffing#240757
Merged
DonJayamanne merged 1 commit intomainfrom Feb 14, 2025
Merged
Ignore internal cell id when computing cell hash for diffing#240757DonJayamanne merged 1 commit intomainfrom
DonJayamanne merged 1 commit intomainfrom
Conversation
DonJayamanne
commented
Feb 14, 2025
| hashValue = doHash(this.getValue(), hashValue); | ||
| hashValue = doHash(this.metadata, hashValue); | ||
| hashValue = doHash(this.internalMetadata, hashValue); | ||
| hashValue = doHash({ ...this.internalMetadata, 'cellId': '' }, hashValue); |
Contributor
Author
There was a problem hiding this comment.
Temporary work around for issue caused by #240733
Basically simple scenarios such as inserting a single cell at the top/middle causes diff editor to not work as expected (all cells is marked as changed with a new cell at the bottom)
Either we revert the PR or just add a work around and fix the known issues,
Going with the latter
lszomoru
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.