Skip to content

Allow tool confirmations and input#244010

Merged
jrieken merged 1 commit intomainfrom
joh/historical-beaver
Mar 19, 2025
Merged

Allow tool confirmations and input#244010
jrieken merged 1 commit intomainfrom
joh/historical-beaver

Conversation

@jrieken
Copy link
Member

@jrieken jrieken commented Mar 19, 2025

  • adds ability to render tool input
  • allows users to tweak/edit input
  • let MCP tools use this
  • make input/message part of tool confirmation collapsiable

* adds ability to render tool input
* allows users to tweak/edit input
* let MCP tools use this
* make input/message part of tool confirmation collapsiable
@jrieken jrieken self-assigned this Mar 19, 2025
@jrieken jrieken enabled auto-merge (squash) March 19, 2025 15:35
@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 19, 2025
@jrieken
Copy link
Member Author

jrieken commented Mar 19, 2025

fyi @roblourens - followed the path of IChatTerminalToolInvocationData with an input-data-type. Hope that matches the intentions here

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should have the styling match the styling of expandable tool messages too

@jrieken jrieken merged commit 9a17684 into main Mar 19, 2025
8 checks passed
@jrieken jrieken deleted the joh/historical-beaver branch March 19, 2025 15:48
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants