Skip to content

fix: re-enable PlzDedicatedWorker feature#244144

Merged
deepak1556 merged 3 commits intomainfrom
robo/enable_plzdedicated_worker
Mar 24, 2025
Merged

fix: re-enable PlzDedicatedWorker feature#244144
deepak1556 merged 3 commits intomainfrom
robo/enable_plzdedicated_worker

Conversation

@deepak1556
Copy link
Copy Markdown
Collaborator

@deepak1556 deepak1556 commented Mar 20, 2025

Fixes #244143

Refs #244143 (comment) for context

@deepak1556 deepak1556 added this to the March 2025 milestone Mar 20, 2025
@deepak1556 deepak1556 requested a review from mjbvz March 20, 2025 18:08
@deepak1556 deepak1556 self-assigned this Mar 20, 2025
@deepak1556 deepak1556 marked this pull request as ready for review March 20, 2025 18:11
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tracking this down!

@deepak1556 deepak1556 requested a review from mjbvz March 20, 2025 18:18
@deepak1556 deepak1556 enabled auto-merge (squash) March 20, 2025 18:32
@deepak1556
Copy link
Copy Markdown
Collaborator Author

@mjbvz I have made an isolated sample to demonstrate the clients chosen when the feature is disabled vs enabled at #244143 (comment).

Tl:dr,

  • With the feature disabled: page, dedicated worker main resource, dedicated worker sub resources, blob worker all use the same window clients (i-e the frame the workers are associated with)
  • With the feature enabled:
    • page and dedicated worker main resource share the same client
    • dedicated worker sub resources has a separate worker client that can be obtained via self.clients.get
    • blob worker has a separate worker client that cannot be obtained via self.clients.get and needs to rely on self.clients.matchAll

@deepak1556 deepak1556 marked this pull request as draft March 21, 2025 17:07
auto-merge was automatically disabled March 21, 2025 17:07

Pull request was converted to draft

@deepak1556 deepak1556 marked this pull request as ready for review March 21, 2025 17:13
@deepak1556 deepak1556 enabled auto-merge (squash) March 21, 2025 17:22
@deepak1556 deepak1556 merged commit 06080ae into main Mar 24, 2025
8 checks passed
@deepak1556 deepak1556 deleted the robo/enable_plzdedicated_worker branch March 24, 2025 16:22
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable plzdedicatedworker feature

2 participants