chore: pass webviewID with initial version message to sw#244910
Merged
deepak1556 merged 1 commit intomainfrom Mar 27, 2025
Merged
chore: pass webviewID with initial version message to sw#244910deepak1556 merged 1 commit intomainfrom
deepak1556 merged 1 commit intomainfrom
Conversation
mjbvz
approved these changes
Mar 27, 2025
deepak1556
added a commit
that referenced
this pull request
Apr 1, 2025
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
Apr 13, 2025
…rosoft#244910)" This reverts commit 1919326.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #244144 we pass the webviewID information as part of the sw registration url, this causes a new worker to be registered for every webview. The ID information is only needed for the resource loads from the webview, so we can pass it as part of the initial
versionmessage and keep the sw controller unchanged.