don't show the view container title if it matches the view pane title#268065
Merged
don't show the view container title if it matches the view pane title#268065
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the view pane title display logic to avoid showing redundant container titles when they match the view pane title. The change adds an additional condition to prevent displaying "Container: Title" when the container title and view title are identical.
Key Changes
- Added condition to check if the view pane title matches the container title before displaying both
- Added debug logging to trace title calculation logic
| const isDefault = this.viewDescriptorService.getDefaultContainerById(this.id) === viewContainer; | ||
|
|
||
| if (!isDefault && viewDescriptor?.containerTitle && model.title !== viewDescriptor.containerTitle) { | ||
| console.log(`Calculating title: isDefault(${isDefault}), containerTitle(${viewDescriptor?.containerTitle}), modelTitle(${model.title})`); |
There was a problem hiding this comment.
Debug console.log statement should be removed before merging to production. Consider using a proper logging mechanism or removing this temporary debugging code.
Suggested change
| console.log(`Calculating title: isDefault(${isDefault}), containerTitle(${viewDescriptor?.containerTitle}), modelTitle(${model.title})`); | |
| // Debug statement removed; use proper logging if needed. |
rzhao271
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @sandy081 @benibenj