Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a TypeScript type casting issue by removing an unsafe any cast and adding proper type checking. The change ensures type safety when modifying command arguments in the code action controller.
Key Changes
- Replaces unsafe
anycast with proper type checking usingArray.isArray() - Removes the ESLint disable comment that was suppressing the
no-any-castsrule
| if (command.arguments && command.arguments.length >= 1) { | ||
| // eslint-disable-next-line local/code-no-any-casts | ||
| command.arguments[0] = { ...(command.arguments[0] as any), autoSend: false }; | ||
| if (command.arguments && command.arguments.length >= 1 && Array.isArray(command.arguments[0])) { |
There was a problem hiding this comment.
The type check Array.isArray(command.arguments[0]) is incorrect. The code is trying to spread command.arguments[0] as an object with { ...command.arguments[0], autoSend: false }, but arrays cannot be spread into objects this way. This should check if command.arguments[0] is an object instead.
Suggested change
| if (command.arguments && command.arguments.length >= 1 && Array.isArray(command.arguments[0])) { | |
| if ( | |
| command.arguments && | |
| command.arguments.length >= 1 && | |
| typeof command.arguments[0] === 'object' && | |
| command.arguments[0] !== null && | |
| !Array.isArray(command.arguments[0]) | |
| ) { |
3a39595 to
66a3043
Compare
dmitrivMS
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #269213