fix https://github.com/microsoft/vscode/issues/260092#270211
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the border width calculation for the suggest widget details was not properly dynamic based on the theme type. The fix removes the static border width property and replaces it with dynamic calculation based on whether the current theme is high contrast.
- Moves border width calculation from static property to dynamic method based on theme
- Removes theme change event handling that was setting border width statically
- Updates border width access to use the new dynamic calculation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/editor/contrib/suggest/browser/suggestWidgetDetails.ts | Adds theme service dependency and implements dynamic border width calculation in getLayoutInfo() method, removes static borderWidth property |
| src/vs/editor/contrib/suggest/browser/suggestWidget.ts | Removes theme change handling and updates border width access to use dynamic calculation from details widget |
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| import * as dom from '../../../../base/browser/dom.js'; | ||
| import { ResizableHTMLElement } from '../../../../base/browser/ui/resizable/resizable.js'; |
There was a problem hiding this comment.
The ResizableHTMLElement import was moved to the top but appears to be unused in the visible code changes. Consider verifying if this import is actually needed.
Suggested change
| import { ResizableHTMLElement } from '../../../../base/browser/ui/resizable/resizable.js'; |
lramos15
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.