Skip to content

fix https://github.com/microsoft/vscode/issues/260092#270211

Merged
jrieken merged 1 commit intomainfrom
joh/fierce-bandicoot
Oct 8, 2025
Merged

fix https://github.com/microsoft/vscode/issues/260092#270211
jrieken merged 1 commit intomainfrom
joh/fierce-bandicoot

Conversation

@jrieken
Copy link
Member

@jrieken jrieken commented Oct 7, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 7, 2025 14:10
@jrieken jrieken enabled auto-merge (squash) October 7, 2025 14:10
@jrieken jrieken self-assigned this Oct 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the border width calculation for the suggest widget details was not properly dynamic based on the theme type. The fix removes the static border width property and replaces it with dynamic calculation based on whether the current theme is high contrast.

  • Moves border width calculation from static property to dynamic method based on theme
  • Removes theme change event handling that was setting border width statically
  • Updates border width access to use the new dynamic calculation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vs/editor/contrib/suggest/browser/suggestWidgetDetails.ts Adds theme service dependency and implements dynamic border width calculation in getLayoutInfo() method, removes static borderWidth property
src/vs/editor/contrib/suggest/browser/suggestWidget.ts Removes theme change handling and updates border width access to use dynamic calculation from details widget

*--------------------------------------------------------------------------------------------*/

import * as dom from '../../../../base/browser/dom.js';
import { ResizableHTMLElement } from '../../../../base/browser/ui/resizable/resizable.js';
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ResizableHTMLElement import was moved to the top but appears to be unused in the visible code changes. Consider verifying if this import is actually needed.

Suggested change
import { ResizableHTMLElement } from '../../../../base/browser/ui/resizable/resizable.js';

Copilot uses AI. Check for mistakes.
@vs-code-engineering vs-code-engineering bot added this to the October 2025 milestone Oct 7, 2025
@jrieken jrieken merged commit d5b9cdb into main Oct 8, 2025
38 of 39 checks passed
@jrieken jrieken deleted the joh/fierce-bandicoot branch October 8, 2025 09:14
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants