Skip to content

Inline chat v2 updates#273986

Merged
jrieken merged 21 commits intomainfrom
joh/fixed-hoverfly
Oct 29, 2025
Merged

Inline chat v2 updates#273986
jrieken merged 21 commits intomainfrom
joh/fixed-hoverfly

Conversation

@jrieken
Copy link
Member

@jrieken jrieken commented Oct 29, 2025

Make the UI more lean

  • have less commands
  • have no more request-response parts
  • no more "hide on request" mode
  • add the exit-tool for the new intent

To be done

  • remove some suggestions and context that doesn't make sense for inline
  • better in-progress UI
Screen.Recording.2025-10-29.at.17.01.35.mov

Copilot AI review requested due to automatic review settings October 29, 2025 16:20
@jrieken jrieken enabled auto-merge (squash) October 29, 2025 16:20
@jrieken jrieken self-assigned this Oct 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the inline chat feature by removing the hideOnRequest configuration option and simplifying the inline chat widget behavior. The changes focus on streamlining the inline chat experience and introducing a new escape tool that allows moving inline chat sessions to panel chat.

Key changes:

  • Removes the hideOnRequest configuration setting and related logic
  • Adds a new InlineChatEscapeToolContribution that enables AI models to suggest moving complex tasks to panel chat
  • Refactors action classes by consolidating UndoSessionAction2 and CloseSessionAction2 into a single UndoAndCloseSessionAction2
  • Updates getSession2 to support lookup by both URI and session ID
  • Adds diagnostic attachment support for inline chat

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/vs/workbench/contrib/inlineChat/common/inlineChat.ts Removes HideOnRequest configuration key and its registration
src/vs/workbench/contrib/inlineChat/browser/inlineChatWidget.ts Adds chat widget input reset in the reset() method
src/vs/workbench/contrib/inlineChat/browser/inlineChatStrategies.ts Adds sessionId: undefined to metadata
src/vs/workbench/contrib/inlineChat/browser/inlineChatSessionServiceImpl.ts Removes hideOnRequest observable, refactors getSession2 for dual lookup, adds InlineChatEscapeToolContribution class
src/vs/workbench/contrib/inlineChat/browser/inlineChatSessionService.ts Removes hideOnRequest from service interface, adds moveToPanelChat helper function, adds session ID overload to getSession2
src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts Removes hideOnRequest logic, simplifies widget visibility, adds diagnostic attachment support, refactors widget configuration
src/vs/workbench/contrib/inlineChat/browser/inlineChatActions.ts Consolidates action classes, updates keybindings and menu configurations
src/vs/workbench/contrib/inlineChat/browser/inlineChat.contribution.ts Registers InlineChatEscapeToolContribution and removes UndoSessionAction2 registration
src/vs/workbench/contrib/chat/common/chatEditingService.ts Adds diffInfo property to IModifiedFileEntry interface
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingTextModelChangeService.ts Refactors edit source creation into separate method, adds session-specific edit source tracking
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingModifiedDocumentEntry.ts Implements diffInfo getter
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingEditorOverlay.ts Removes hideOnRequest check from overlay controller
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingEditorActions.ts Simplifies preconditions and menu conditions
src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts Adds menu items for inline chat execute
src/vs/workbench/contrib/chat/browser/actions/chatContextActions.ts Extends AttachContextAction menu to support inline chat
src/vs/platform/actions/common/actions.ts Adds new menu IDs for inline chat editor
src/vs/editor/common/textModelEditSource.ts Adds sessionId parameter to inlineChatApplyEdit

…er.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jrieken jrieken merged commit 35d4ea1 into main Oct 29, 2025
29 of 38 checks passed
@jrieken jrieken deleted the joh/fixed-hoverfly branch October 29, 2025 22:21
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants