Conversation
* add the minimun number of command only * add keep/discard commands
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the inline chat feature by removing the hideOnRequest configuration option and simplifying the inline chat widget behavior. The changes focus on streamlining the inline chat experience and introducing a new escape tool that allows moving inline chat sessions to panel chat.
Key changes:
- Removes the
hideOnRequestconfiguration setting and related logic - Adds a new
InlineChatEscapeToolContributionthat enables AI models to suggest moving complex tasks to panel chat - Refactors action classes by consolidating
UndoSessionAction2andCloseSessionAction2into a singleUndoAndCloseSessionAction2 - Updates
getSession2to support lookup by both URI and session ID - Adds diagnostic attachment support for inline chat
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/inlineChat/common/inlineChat.ts |
Removes HideOnRequest configuration key and its registration |
src/vs/workbench/contrib/inlineChat/browser/inlineChatWidget.ts |
Adds chat widget input reset in the reset() method |
src/vs/workbench/contrib/inlineChat/browser/inlineChatStrategies.ts |
Adds sessionId: undefined to metadata |
src/vs/workbench/contrib/inlineChat/browser/inlineChatSessionServiceImpl.ts |
Removes hideOnRequest observable, refactors getSession2 for dual lookup, adds InlineChatEscapeToolContribution class |
src/vs/workbench/contrib/inlineChat/browser/inlineChatSessionService.ts |
Removes hideOnRequest from service interface, adds moveToPanelChat helper function, adds session ID overload to getSession2 |
src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts |
Removes hideOnRequest logic, simplifies widget visibility, adds diagnostic attachment support, refactors widget configuration |
src/vs/workbench/contrib/inlineChat/browser/inlineChatActions.ts |
Consolidates action classes, updates keybindings and menu configurations |
src/vs/workbench/contrib/inlineChat/browser/inlineChat.contribution.ts |
Registers InlineChatEscapeToolContribution and removes UndoSessionAction2 registration |
src/vs/workbench/contrib/chat/common/chatEditingService.ts |
Adds diffInfo property to IModifiedFileEntry interface |
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingTextModelChangeService.ts |
Refactors edit source creation into separate method, adds session-specific edit source tracking |
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingModifiedDocumentEntry.ts |
Implements diffInfo getter |
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingEditorOverlay.ts |
Removes hideOnRequest check from overlay controller |
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingEditorActions.ts |
Simplifies preconditions and menu conditions |
src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts |
Adds menu items for inline chat execute |
src/vs/workbench/contrib/chat/browser/actions/chatContextActions.ts |
Extends AttachContextAction menu to support inline chat |
src/vs/platform/actions/common/actions.ts |
Adds new menu IDs for inline chat editor |
src/vs/editor/common/textModelEditSource.ts |
Adds sessionId parameter to inlineChatApplyEdit |
src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts
Outdated
Show resolved
Hide resolved
…er.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mjbvz
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the UI more lean
To be done
Screen.Recording.2025-10-29.at.17.01.35.mov