remove proposedAPI check for chatAgent contributions#274758
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the chatParticipantPrivate API proposal check for the chatAgents contribution point. The check was previously enforcing that extensions must have the chatParticipantPrivate API proposal enabled to contribute to the chatAgents extension point.
- Removes the unused import of
checkProposedApiEnabledfunction - Removes the conditional API proposal check for
chatAgentscontributions
| private handle(extensionPoint: extensionsRegistry.IExtensionPoint<IRawChatFileContribution[]>, contributionPoint: ChatContributionPoint) { | ||
| extensionPoint.setHandler((_extensions, delta) => { | ||
| for (const ext of delta.added) { | ||
| if (contributionPoint === 'chatAgents') { | ||
| checkProposedApiEnabled(ext.description, 'chatParticipantPrivate'); | ||
| } | ||
| const type = pointToType(contributionPoint); | ||
| for (const raw of ext.value) { |
There was a problem hiding this comment.
The removal of the checkProposedApiEnabled(ext.description, 'chatParticipantPrivate') check for the chatAgents contribution point means that any extension can now contribute chat agents without requiring the chatParticipantPrivate proposed API to be enabled. This change should be verified against the intended security posture, as other parts of the codebase (e.g., languageModelToolsContribution.ts lines 228, 233) still enforce restrictions on copilot_ and vscode_ prefixes based on this API proposal. Ensure this relaxation is intentional and that appropriate validations exist elsewhere (e.g., name prefix restrictions) to prevent unauthorized extensions from registering privileged chat agents.
No description provided.