Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR configures SDL (Security Development Lifecycle) suppression settings for the Windows build pipeline and updates the Guardian documentation reference URL.
- Adds SDL suppression configuration to the Windows product build pipeline
- Updates the Guardian help URI from "baselines" to "suppressions" documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build/azure-pipelines/win32/product-build-win32.yml | Adds SDL suppression configuration pointing to the Guardian suppression file |
| .config/guardian/.gdnsuppress | Updates help URI to point to the correct "suppressions" documentation page |
deepak1556
approved these changes
Nov 4, 2025
Collaborator
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
Should we run a build to confirm the suppressions are picked up ?
Collaborator
Author
|
Will check on Friday or during debt week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppresses the warnings now that we have tried to resolve them.