Skip to content

fix tab drag and drop#275706

Merged
meganrogge merged 2 commits intomainfrom
merogge/tab-drop
Nov 5, 2025
Merged

fix tab drag and drop#275706
meganrogge merged 2 commits intomainfrom
merogge/tab-drop

Conversation

@meganrogge
Copy link
Collaborator

fix #275592

Adding the chat entry wrapped the tabs list in an extra container. When you would drag a tab into the empty area (which is now that container instead of the list), the list’s drop handler would never runs. The fix watches for drops on the container/chat entry, recognizes terminal drags, and forwards them to the usual “move to end” logic, so behavior matches what we had before.

demo.mov

Copilot AI review requested due to automatic review settings November 5, 2025 23:02
@meganrogge meganrogge self-assigned this Nov 5, 2025
@meganrogge meganrogge added this to the October 2025 milestone Nov 5, 2025
@meganrogge meganrogge enabled auto-merge (squash) November 5, 2025 23:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds drag-and-drop support for the empty area in the terminal tabs view, allowing users to drop terminal tabs onto the empty space at the end of the tab list.

  • Adds event listeners for drag-and-drop operations (dragenter, dragover, dragleave, drop) on the tab container
  • Implements logic to handle dropping terminals into the empty area, moving them to the end of the tab list
  • Adds visual feedback with CSS styling when dragging over the drop target area

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts Adds drag-and-drop event handlers, helper methods, and state management for empty area terminal drops
src/vs/workbench/contrib/terminal/browser/media/terminal.css Adds visual styling for the drop target indicator on the tabs list container

@meganrogge meganrogge merged commit e4bcfcb into main Nov 5, 2025
33 of 34 checks passed
@meganrogge meganrogge deleted the merogge/tab-drop branch November 5, 2025 23:42
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dragging a terminal tab to the bottom of tab list no longer works

3 participants