Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds drag-and-drop support for the empty area in the terminal tabs view, allowing users to drop terminal tabs onto the empty space at the end of the tab list.
- Adds event listeners for drag-and-drop operations (
dragenter,dragover,dragleave,drop) on the tab container - Implements logic to handle dropping terminals into the empty area, moving them to the end of the tab list
- Adds visual feedback with CSS styling when dragging over the drop target area
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts | Adds drag-and-drop event handlers, helper methods, and state management for empty area terminal drops |
| src/vs/workbench/contrib/terminal/browser/media/terminal.css | Adds visual styling for the drop target indicator on the tabs list container |
benibenj
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #275592
Adding the chat entry wrapped the tabs list in an extra container. When you would drag a tab into the empty area (which is now that container instead of the list), the list’s drop handler would never runs. The fix watches for drops on the container/chat entry, recognizes terminal drags, and forwards them to the usual “move to end” logic, so behavior matches what we had before.
demo.mov