Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where WSL distribution detection fails when users have enabled UTF-8 mode via the WSL_UTF8 environment variable. The change ensures consistent UTF-16LE encoding by explicitly setting WSL_UTF8=0 when executing wsl.exe -l -q.
Key Changes:
- Modified the
getWslProfilesfunction to explicitly disable UTF-8 mode when listing WSL distributions - Updated comment to explain why the encoding must be forced
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lszomoru
approved these changes
Nov 10, 2025
rzhao271
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #276253