Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors DOM traversal logic for hiding twistie elements in tree views by replacing complex parent navigation with simpler sibling access.
- Simplifies the approach to access the
.monaco-tl-twistieelement in tree renderers - Replaces
container.parentElement.parentElement.querySelector('.monaco-tl-twistie')withcontainer.previousElementSibling - Removes unnecessary eslint-disable comments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/processExplorer/browser/processExplorerControl.ts | Simplified twistie element access in ProcessHeaderTreeRenderer using previousElementSibling |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts | Simplified twistie element access in AgentSessionRenderer using previousElementSibling |
lszomoru
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.