Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses model disposal issues in the inline edits view by ensuring proper null checks for both the model and text model before operations that depend on them.
Key Changes:
- Added reactive text model checks in the
_uiStatederived computation to prevent errors when the model is disposed - Updated the viewZone management to read the text model reactively instead of using a static reference
- Made the viewZoneId check more explicit by changing from a falsy check to a strict undefined comparison
bpasero
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Address the issue of model disposal by ensuring that both the model and text model are checked before proceeding with operations. Update conditions to prevent errors related to undefined models.fixes #263234