Add comment draft color to overview ruler#276972
Merged
Conversation
rzhao271
approved these changes
Nov 12, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new color theme token for comment threads with draft comments in the overview ruler, providing better visual distinction for drafts.
- Introduces
editorOverviewRuler.commentDraftForegroundcolor token - Updates the overview ruler color logic to prioritize draft status over resolved/unresolved states
- Registers the new CSS variable in the stylelint configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/comments/browser/commentGlyphWidget.ts | Registers new overviewRulerCommentDraftForeground color and updates decoration logic to use draft color when _threadHasDraft is true |
| build/lib/stylelint/vscode-known-variables.json | Adds --vscode-editorOverviewRuler-commentDraftForeground CSS variable to the known variables list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RE: #271536 (comment)