Fix leak errors from disposed ChatThinkingContentPart during thinking stream#277264
Merged
vijayupadya merged 11 commits intomicrosoft:mainfrom Nov 13, 2025
Merged
Conversation
chrmarti
approved these changes
Nov 13, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes memory leak errors that occurred when asynchronous streaming updates arrived for a ChatThinkingContentPart after it had already been disposed. The root cause was that during rapid operations like regeneration, view switching, or collapse/expand, the part could be disposed while async updates were still in flight.
Key Changes
- Added disposal guards using
this._store.isDisposedchecks in three critical methods - Prevents registration of new disposables on disposed objects
- Follows established disposal pattern used throughout the codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #277260
Fixes leak errors when late thinking updates tried to register disposables on an already disposed ChatThinkingContentPart.
Root Cause
Asynchronous streaming updates (title/thinking text) continued arriving for a stale ChatThinkingContentPart after it was disposed (list diff, deletion, regenerate).
Few scenarios to repro: