Add oldName and newName to the meta data of a rename detailed reason.#277448
Merged
Add oldName and newName to the meta data of a rename detailed reason.#277448
Conversation
…y never used as key to identify the edit
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds oldName and newName metadata to the rename edit source for better tracking and telemetry of rename operations.
- Enhances the
EditSources.rename()function to accept and store old and new symbol names - Uses the
$$$prefix (highest privacy level) for these metadata fields to protect potentially sensitive symbol names - Updates the call site to pass the old name (
loc?.text) and new name (inputFieldResult.newName) when creating rename edit sources
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/editor/common/textModelEditSource.ts | Modified EditSources.rename() to accept oldName and newName parameters and store them as $$$oldName and $$$newName metadata with highest privacy protection |
| src/vs/editor/contrib/rename/browser/rename.ts | Updated the rename operation to pass the old symbol name and new symbol name to EditSources.rename() when applying bulk edits |
hediet
approved these changes
Nov 17, 2025
bpasero
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.