Skip to content

Uses this instead of static class reference to fix esbuild static initializer problem#278172

Merged
hediet merged 1 commit intomainfrom
hediet/b/unemployed-chameleon
Nov 18, 2025
Merged

Uses this instead of static class reference to fix esbuild static initializer problem#278172
hediet merged 1 commit intomainfrom
hediet/b/unemployed-chameleon

Conversation

@hediet
Copy link
Member

@hediet hediet commented Nov 18, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 18, 2025 18:28
@hediet hediet enabled auto-merge (squash) November 18, 2025 18:28
@hediet hediet self-assigned this Nov 18, 2025
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/browser/parts/editor/editorPlaceholder.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an esbuild static initializer problem by replacing explicit class name references with this in static field initializers within two editor placeholder classes.

  • Replaces WorkspaceTrustRequiredPlaceholderEditor with this in the static DESCRIPTOR field
  • Replaces ErrorPlaceholderEditor with this in the static DESCRIPTOR field

@hediet hediet merged commit 3e7a2f2 into main Nov 18, 2025
33 of 34 checks passed
@hediet hediet deleted the hediet/b/unemployed-chameleon branch November 18, 2025 18:58
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants