Skip to content

followup fix#278182

Merged
connor4312 merged 1 commit intomainfrom
severe-warbler
Nov 18, 2025
Merged

followup fix#278182
connor4312 merged 1 commit intomainfrom
severe-warbler

Conversation

@connor4312
Copy link
Member

No description provided.

@connor4312 connor4312 enabled auto-merge (squash) November 18, 2025 19:10
@connor4312 connor4312 self-assigned this Nov 18, 2025
Copilot AI review requested due to automatic review settings November 18, 2025 19:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the ChatElicitationRequestPart class to improve encapsulation of the reject functionality. The main change involves converting the _reject constructor parameter into a private implementation with a public reject method that wraps the rejection logic and updates the component's state.

Key Changes:

  • Makes _accept parameter private for better encapsulation
  • Converts _reject constructor parameter to a local reject parameter and initializes a public reject method that handles state updates
  • Adds a public reject property to the class

@vs-code-engineering vs-code-engineering bot added this to the November 2025 milestone Nov 18, 2025
@connor4312 connor4312 merged commit 65a9d0b into main Nov 18, 2025
28 checks passed
@connor4312 connor4312 deleted the severe-warbler branch November 18, 2025 20:22
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants