Skip to content

Remove dead code#278202

Merged
benibenj merged 1 commit intomainfrom
benibenj/uncertain-pig
Nov 18, 2025
Merged

Remove dead code#278202
benibenj merged 1 commit intomainfrom
benibenj/uncertain-pig

Conversation

@benibenj
Copy link
Contributor

Copilot Generated Description: Eliminate unused code and imports to streamline the codebase.

Copilot AI review requested due to automatic review settings November 18, 2025 20:08
@benibenj benibenj enabled auto-merge November 18, 2025 20:08
@benibenj benibenj self-assigned this Nov 18, 2025
@vs-code-engineering vs-code-engineering bot added this to the November 2025 milestone Nov 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused code from the InlineEditsLongDistanceHint class, including dead imports, constants, methods, and observables that are no longer referenced.

  • Removed unused imports (IMouseEvent, Emitter) and updated to use Event.None for the click handler
  • Removed unused constants (BORDER_WIDTH, ORIGINAL_END_PADDING, MODIFIED_END_PADDING) and a static method (fitsInsideViewport)
  • Removed unused observables and their declarations (_hintTopLeft, _bottomOfHintLine, _topOfHintLine)

@benibenj benibenj closed this Nov 18, 2025
auto-merge was automatically disabled November 18, 2025 22:06

Pull request was closed

@benibenj benibenj reopened this Nov 18, 2025
@benibenj benibenj enabled auto-merge (squash) November 18, 2025 22:17
@benibenj benibenj merged commit 19e10f7 into main Nov 18, 2025
53 of 60 checks passed
@benibenj benibenj deleted the benibenj/uncertain-pig branch November 18, 2025 22:27
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants