Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes PII (Personally Identifiable Information) redaction in error telemetry by correcting the cleanup pattern and adds comprehensive test coverage to verify that user paths are properly removed from stack traces while preserving important code paths.
Key changes:
- Fixed the cleanup pattern regex to properly match file URIs with two slashes instead of three
- Added six new test cases covering Windows, macOS, and Linux PII redaction for both unexpected and uncaught errors
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/platform/telemetry/common/telemetryService.ts | Fixed regex pattern from three to two slashes to correctly match vscode-file:// URIs |
| src/vs/platform/telemetry/test/browser/telemetryService.test.ts | Added comprehensive test coverage for PII redaction across Windows, macOS, and Linux platforms |
lszomoru
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/microsoft/vscode-internalbacklog/issues/6316