Merged
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jriekenMatched files:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue where mirroring output item edits between notebook models caused unintended shared state. The PR removes the mirroring logic for NotebookCellsChangeType.OutputItem events, relying instead on the fact that output data arrays are already shared by reference between the original and modified notebook models.
Key changes:
- Removed mirroring of
NotebookCellsChangeType.OutputItemevents from modified to original model - Added a comment explaining that outputs are shared between models
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingModifiedNotebookEntry.ts
Show resolved
Hide resolved
DonJayamanne
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #270699
When we mirror the output edits, the actual output object is passed through to be stored on the cell of each model, so later appending to the output item of one model will affect both.
We could duplicate the outputs instead, but copilot cannot directly edit outputs, so I think it's fine to share them between the two models.