white apple logo for all themes except high contrast white#278673
Merged
eli-w-king merged 2 commits intomainfrom Nov 21, 2025
Merged
white apple logo for all themes except high contrast white#278673eli-w-king merged 2 commits intomainfrom
eli-w-king merged 2 commits intomainfrom
Conversation
eli-w-king
changed the title
eli-w-king
added
ux
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to adjust the Apple logo styling for the chat setup dialog to use a white logo for all themes except high contrast light. However, the implementation has a critical bug that would cause visibility issues in the light theme.
Key Change
- Modified Apple logo asset selection rules to use white logo (
apple-dark.svg) by default and black logo (apple-light.svg) only forhc-lighttheme
Comment on lines
+58
to
60
| .chat-setup-dialog .dialog-buttons-row > .dialog-buttons > .monaco-button.continue-button.apple::before { | ||
| background-image: url('./apple-dark.svg'); | ||
| } |
There was a problem hiding this comment.
The default rule on line 58 will apply to ALL themes including .vs (light theme), resulting in a white Apple logo on a light background which would be invisible or very hard to see.
The implementation should follow the established pattern seen in other parts of the codebase (e.g., src/vs/workbench/browser/parts/editor/media/editorgroupview.css lines 52-72). The correct approach would be:
/* Default/base for light themes */
.chat-setup-dialog .dialog-buttons-row > .dialog-buttons > .monaco-button.continue-button.apple::before {
background-image: url('./apple-light.svg');
}
/* Dark themes get white logo */
.monaco-workbench.vs-dark .chat-setup-dialog .dialog-buttons-row > .dialog-buttons > .monaco-button.continue-button.apple::before,
.monaco-workbench.hc-black .chat-setup-dialog .dialog-buttons-row > .dialog-buttons > .monaco-button.continue-button.apple::before {
background-image: url('./apple-dark.svg');
}
/* High contrast light explicitly uses black logo (optional if same as default) */
.monaco-workbench.hc-light .chat-setup-dialog .dialog-buttons-row > .dialog-buttons > .monaco-button.continue-button.apple::before {
background-image: url('./apple-light.svg');
}This ensures proper contrast for each theme type.
See below for a potential fix:
/* Default/base for light themes */
.chat-setup-dialog .dialog-buttons-row > .dialog-buttons > .monaco-button.continue-button.apple::before {
background-image: url('./apple-light.svg');
}
/* Dark themes get white logo */
.monaco-workbench.vs-dark .chat-setup-dialog .dialog-buttons-row > .dialog-buttons > .monaco-button.continue-button.apple::before,
.monaco-workbench.hc-black .chat-setup-dialog .dialog-buttons-row > .dialog-buttons > .monaco-button.continue-button.apple::before {
background-image: url('./apple-dark.svg');
}
/* High contrast light explicitly uses black logo (optional if same as default) */
.monaco-workbench.hc-light .chat-setup-dialog .dialog-buttons-row > .dialog-buttons > .monaco-button.continue-button.apple::before {
background-image: url('./apple-light.svg');
}
bpasero
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using black apple logo for white high contrast theme, using white logo for all others.