Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a validation check to the rename suggestion logic in the inline completions feature. The fix ensures that the text identified at the rename position by the language service matches the expected old name before allowing a rename operation to proceed, preventing incorrect rename suggestions when symbols don't match expectations.
Key Changes
- Added
loc.text === oldNamevalidation to therenamePossiblecondition to ensure rename suggestions are only created when the symbol at the position matches what was identified by diff analysis
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
bpasero
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Update the rename suggestion logic to ensure that the old name matches the text before allowing a rename to proceed.fixes https://github.com/microsoft/vscode-copilot-issues/issues/367