Skip to content

agent sessions - polish for chat view integration#279448

Merged
bpasero merged 2 commits intomainfrom
ben/everyday-swordtail
Nov 25, 2025
Merged

agent sessions - polish for chat view integration#279448
bpasero merged 2 commits intomainfrom
ben/everyday-swordtail

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Nov 25, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 25, 2025 20:38
@bpasero bpasero enabled auto-merge (squash) November 25, 2025 20:38
@bpasero bpasero self-assigned this Nov 25, 2025
@vs-code-engineering vs-code-engineering bot added this to the November 2025 milestone Nov 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds polish for integrating agent sessions into the chat view pane, implementing UI improvements and filtering capabilities to display a curated list of active sessions. The changes enable the chat view to show a limited set of relevant sessions (non-archived, with requests) with proper focus management and styling.

  • Added session limiting functionality to show only the top 3 most recent sessions
  • Implemented filtering to exclude archived sessions and empty sessions from the chat view
  • Enhanced UI with flex-grow layout and rounded borders for better visual integration
  • Added focus clearing to improve user experience during empty state transitions

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/vs/workbench/contrib/chat/browser/media/chatViewPane.css Updated styling for agent sessions container with flex-grow, padding, and border-radius for list rows
src/vs/workbench/contrib/chat/browser/chatViewPane.ts Added clearFocus call on empty state change and implemented session filtering with limitResults set to 3, excluding archived sessions and sessions without requests
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts Extended IAgentSessionsFilter interface with optional limitResults property and updated AgentSessionsDataSource to accept sorter and implement sorting/limiting logic
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts Refactored sorter instantiation to reuse same instance in both data source and tree options, and added clearFocus method to clear focus and selection

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bpasero bpasero merged commit 98ab566 into main Nov 25, 2025
28 checks passed
@bpasero bpasero deleted the ben/everyday-swordtail branch November 25, 2025 21:13
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants