remove duplicate code with MenuId.ChatNewMenu#280437
Merged
joshspicer merged 1 commit intomainfrom Dec 1, 2025
Merged
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes duplicate menu registration code for chat session types by consolidating the menu registration into the dynamic action registration mechanism in ChatSessionsService.
Key Changes:
- Removed two hardcoded action classes (
NewBackgroundChatActionandNewCloudChatAction) fromagentSessionsActions.tsthat were only executing dynamically registered commands - Added menu registration to the dynamic action creation in
chatSessions.contribution.tsso all chat session types automatically register to theChatNewMenu - Removed unused imports (
CHAT_CATEGORYandNEW_CHAT_SESSION_ACTION_ID) fromagentSessionsActions.ts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsActions.ts | Removed duplicate action classes for Background and Cloud chat that were wrappers around dynamic commands, and cleaned up unused imports |
| src/vs/workbench/contrib/chat/browser/chatSessions.contribution.ts | Added menu registration to dynamic action creation so all chat session contributions automatically appear in ChatNewMenu |
aiday-mar
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.