Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
joaomoreno
approved these changes
Dec 3, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix an alignment issue with tree items (issue #279421) by restricting when the no-twisty CSS class is applied to tree items. The change limits the class to only be managed for root-level items (items whose parent is the Root instance).
- The fix adds a condition to only add/remove the
no-twistyclass for direct children of the root node
| templateData.container.classList.add('no-twisty'); | ||
| } else { | ||
| templateData.container.classList.remove('no-twisty'); | ||
| } |
There was a problem hiding this comment.
The no-twisty class is not being removed from non-root items when templates are reused. When a template previously used for a root-level leaf node (with no-twisty class) is reused for a non-root item, the class will persist incorrectly.
The fix should ensure the class is removed for non-root items:
if (node.parent instanceof Root) {
if (node.collapsibleState === TreeItemCollapsibleState.None) {
templateData.container.classList.add('no-twisty');
} else {
templateData.container.classList.remove('no-twisty');
}
} else {
templateData.container.classList.remove('no-twisty');
}
Suggested change
| } | |
| } | |
| } else { | |
| templateData.container.classList.remove('no-twisty'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279421