SCM - fix the disposal of artifact commands#280920
Merged
Conversation
jrieken
approved these changes
Dec 3, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the disposal management of artifact commands in the SCM (Source Control Management) extension host API. The change addresses a memory leak issue (related to GitHub issue #280596) by moving the responsibility of managing artifact command disposables from the ExtHostSCM class to individual ExtHostSourceControl instances.
Key changes:
- Moved command disposal tracking from a centralized map to instance-level
DisposableMap - Extracted artifact provision logic into a dedicated method on
ExtHostSourceControl - Ensured proper cleanup when source controls are disposed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #280596