Skip to content

Use different color for voice recording icon/animation#283309

Merged
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/voice-icon-color
Dec 17, 2025
Merged

Use different color for voice recording icon/animation#283309
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/voice-icon-color

Conversation

@dmitrivMS
Copy link
Contributor

@dmitrivMS dmitrivMS commented Dec 13, 2025

Fixes #265676

Tested with light, dark, and the theme from the bug - all look good.

Copilot AI review requested due to automatic review settings December 13, 2025 10:01
@dmitrivMS dmitrivMS requested a review from bpasero December 13, 2025 10:01
@dmitrivMS dmitrivMS enabled auto-merge (squash) December 13, 2025 10:01
@dmitrivMS dmitrivMS self-assigned this Dec 13, 2025
@vs-code-engineering vs-code-engineering bot added this to the December / January 2026 milestone Dec 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the color used for the voice recording icon/animation in the chat interface from ACTIVITY_BAR_BADGE_BACKGROUND (blue notification badge color) to ACTIVITY_BAR_FOREGROUND (white active item color) to provide better visual distinction and semantic correctness for the recording state indicator.

Key Changes

  • Updated the color constant from ACTIVITY_BAR_BADGE_BACKGROUND to ACTIVITY_BAR_FOREGROUND for the active recording animation

@bpasero
Copy link
Member

bpasero commented Dec 13, 2025

Thanks!

@mrleemurray maybe you could also chime in for this color change: the idea is to show the active voice recording icon in a stronger "active" color, that is why I picked the badge color, which is blue in most default themes. But that does not work in all themes, as this issue shows.

@mrleemurray
Copy link
Contributor

I'll investigate an alternative color that is compatible in all themes

@mrleemurray
Copy link
Contributor

I think @dmitrivMS color choice works well - great job!

@dmitrivMS dmitrivMS merged commit ec12d2b into main Dec 17, 2025
33 of 34 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/voice-icon-color branch December 17, 2025 11:16
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Voice icon not showing in certain themes when recording

4 participants