QuickDiff - dispose the quick diff model reference#283565
Merged
Conversation
dmitrivMS
approved these changes
Dec 15, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a memory leak by properly disposing the quick diff model reference returned by createQuickDiffModelReference(). The IReference<QuickDiffModel> must be disposed once it's no longer needed, as documented in the IQuickDiffModelService interface. The fix adds the reference to the toDispose array, which is properly disposed when the text editor is removed or when the MainThreadTextEditors component is disposed.
Key Changes
- Adds disposal of
quickDiffModelRefto prevent memory leaks in extension API diff information tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.